Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.2.3 #2369

Merged
merged 3 commits into from
Nov 27, 2019
Merged

Release 2.2.3 #2369

merged 3 commits into from
Nov 27, 2019

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Nov 24, 2019

No description provided.

@Be-ing Be-ing changed the base branch from master to 2.2 November 24, 2019 21:01
@Be-ing Be-ing added this to the 2.2.3 milestone Nov 24, 2019
@uklotzde
Copy link
Contributor

What about #2358?

@uklotzde
Copy link
Contributor

@daschuer What is the state of https://bugs.launchpad.net/mixxx/+bug/1843922 (marked in progress)

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 25, 2019

What about #2358?

That's a very minor issue and I'm not clear from reading the PR what the state of it is. I don't think it should hold up this overdue release any longer. We can always do more minor releases.

@daschuer
Copy link
Member

What about #2358?

This is a mature to merge. It fixes only a trivial spelling issue. Can one have a look?

@daschuer
Copy link
Member

@daschuer What is the state of https://bugs.launchpad.net/mixxx/+bug/1843922 (marked in progress)

I am unsure how the state is. Need to test. At least nothing that should block merging.

@Holzhaus
Copy link
Member

By the way, we should also publish a blogpost upon release (https://mixxxblog.blogspot.com/). The last one is for release 2.1.3.

@uklotzde
Copy link
Contributor

A changelog entry for #2358 needs to be added.

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 26, 2019

A changelog entry for #2358 needs to be added.

Done

@uklotzde
Copy link
Contributor

Be-ing#39

@Be-ing
Merge pull request #39 from uklotzde/release_2.2.3
d4edbce 
Add lp:1846966 to 2.2.3 changelog
@uklotzde
Copy link
Contributor

LGTM. Anyone else?

@daschuer
Copy link
Member

LGTM, Thank you.

@Be-ing Be-ing merged commit 4d3d17d into mixxxdj:2.2 Nov 27, 2019
@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 27, 2019

As a reminder, do not make the Git tag until we have confirmed the packages work on all 3 OSs.

@Be-ing Be-ing deleted the release_2.2.3 branch November 27, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@Be-ing @uklotzde @daschuer @Holzhaus