Bug 1000784 #26
Bug 1000784 #26
Conversation
coreaudio, flac, modplug, mp3, ogg, snd
| if (result) | ||
| return OK; | ||
| return ERR; | ||
| if (result==ERR) { |
| if (result) | ||
| return OK; | ||
| return ERR; | ||
| if (result==ERR) { |
|
These all look like reasonable error messages to add to the SoundSources but they would only be triggered when we are loading the file (e.g. loading to a deck or analyzing). TagLib is what we use to analyze the files during library scanning and it doesn't look like this changes our taglib code at all (located in src/soundsource.cpp). |
|
Also @troyane, you should merge with master to get the latest changes. I think you have some conflicts with changes I made in soundsourcecoreaudio.cpp in master. |
|
Sorry -- misread. Adding logging for when parseHeader() would return ERR is good but maybe that belongs in the SoundSource::process* functions? That way you could report more details about the erorr (TagLib couldn't parse AudioProperties, etc.) And you don't have to duplicate the error checks in every SoundSource's parseHeader. |
| return OK; | ||
| return ERR; | ||
| if (result == ERR) { | ||
| qWarning() << "Error parsing header of file" << m_qFilename; |
There was a problem hiding this comment.
here is a type mismatch: const int ERR = -1; bool result
|
Please fix also the implicit cast at: |
Improved errors with const int ERR and bool result; avoided implicit cast in soundsource.cpp. Deleted variable qurlStr.
|
For me this is in a merge-able state. But RJ has made a valid point: So it would be nice if you could move all warnings from the bottom of each parseHeader() to By the way: I think setting p->setHeaderParsed(false); looks like a bug, because the Header was actual passed but without success. So it makes no scene to try it again later. |
|
@daschuer, thanks. I'll do it. |
soundsourceproxy.cpp
|
Please, check it, troyane@9f710b4. |
|
@troyane: Thank you! |
First part of Bug 1000784 "Specify file name on scanning error"
That is my first pull request.
My idea was to fix bug https://bugs.launchpad.net/mixxx/+bug/1000784.