Added 'const' or '&' to arguments when needed. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| QFile file(fileName); | ||
| return file.remove(); | ||
| } | ||
|
|
||
| bool AnalysisDao::saveDataToFile(QString fileName, QByteArray data) const { | ||
| bool AnalysisDao::saveDataToFile(const QString& fileName, QByteArray& data) const { |
There was a problem hiding this comment.
bool AnalysisDao::saveDataToFile(const QString& fileName, const QByteArray& data) const {
If track ID List is not used by the callers afterwards, use pointer; output parameters are at the end of the parameter list.
|
LGTM! Thank you. Please note: There is no notification send out if you add a commit. So please write a "finish" comment when you think you are finished. This way the possible reviewers will be informed. |
daschuer
added a commit
that referenced
this pull request
Jul 5, 2013
Added 'const' or '&' to arguments when needed.
|
Thank you, @daschuer. I'll write "finish" every time henceforward. |
Merged
11 tasks
Swiftb0y
pushed a commit
to Swiftb0y/mixxx
that referenced
this pull request
Nov 3, 2019
add AutoDJ icons
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
Configuration updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was learning DAO's code. I found that it would be more simpler to understand code if there are const qualifiers for function arguments. Also, in this way we can avoid some errors and help compiler.
About references -- whenever we don't need object's copy -- we just use it's reference.