Use old *_build folder in case of a new branch #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch avoids a full rebuild for new branches, in a ready build working copy. |
| # no chached build dir found, assume this is a branch from the old branch | ||
| # if not, no problem because scons will rebuild all chaned files in any case | ||
| # copy the old_virtual_dir back | ||
| if old_virtual_build_dir: |
There was a problem hiding this comment.
This will fail with NameError if .sconsign.branch doesn't exist.
|
Thank you @rryan. I have issued fixes for all comments. |
| # no chached build dir found, assume this is a branch from the old branch | ||
| # if not, no problem because scons will rebuild all chaned files in any case | ||
| # copy the old_virtual_dir back | ||
| if sconsign_branch: |
There was a problem hiding this comment.
This if and the two nested ifs (if old_virtual_build_dir and old_virtual_sconsign_file) seem redundant since old_virtual_build_dir will not evaluate to True unless it is a non-empty string and it's only a non-empty string if sconsign_branch is non-empty. Both could probably be removed becuase os.path.isdir('') and isfile('') will return false.
|
LGTM, thanks for the changes! |
daschuer
added a commit
that referenced
this pull request
Jul 10, 2013
Use old *_build folder in case of a new branch
Merged
11 tasks
daschuer
added a commit
that referenced
this pull request
Dec 12, 2018
QCollator: Extensions and minor improvements
Swiftb0y
pushed a commit
to Swiftb0y/mixxx
that referenced
this pull request
Nov 8, 2019
AutoDJProcessorTest.FadeToDeck2_Long_Transition fix
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
Holzhaus
pushed a commit
to Holzhaus/mixxx
that referenced
this pull request
Aug 23, 2020
Chapter 10 split up
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Changed download links to 2.1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.