Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SoundSourceMediaFoundation: Disable debug assertion #3680

Merged
merged 1 commit into from
Mar 9, 2021
Merged

SoundSourceMediaFoundation: Disable debug assertion #3680

merged 1 commit into from
Mar 9, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Mar 9, 2021

@uklotzde uklotzde added this to the 2.3.0 milestone Mar 9, 2021
@uklotzde uklotzde requested a review from Be-ing March 9, 2021 00:24
@Be-ing
Copy link
Contributor

Be-ing commented Mar 9, 2021

Windows build failed:

Error: ..\src\sources\soundsourcemediafoundation.cpp(532): error C2870: '<Unknown>': a namespace definition must appear either at file scope or immediately within another namespace definition
Error: ..\src\sources\soundsourcemediafoundation.cpp(537): error C2601: 'mixxx::`anonymous-namespace'::configureMediaType': local function definitions are illegal
..\src\sources\soundsourcemediafoundation.cpp(532): note: this line contains a '{' which has not yet been matched
Error: ..\src\sources\soundsourcemediafoundation.cpp(695): error C2601: 'mixxx::SoundSourceMediaFoundation::configureAudioStream': local function definitions are illegal
..\src\sources\soundsourcemediafoundation.cpp(276): note: this line contains a '{' which has not yet been matched
Error: ..\src\sources\soundsourcemediafoundation.cpp(791): error C2601: 'mixxx::SoundSourceMediaFoundation::readProperties': local function definitions are illegal
..\src\sources\soundsourcemediafoundation.cpp(276): note: this line contains a '{' which has not yet been matched
..\src\sources\soundsourcemediafoundation.cpp(813): fatal error C1506: unrecoverable block scoping error
[533/818] Building CXX object CMakeFiles\mixxx-lib.dir\src\controllers\hid\hidcontroller.cpp.obj
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.

@Be-ing
Copy link
Contributor

Be-ing commented Mar 9, 2021

Thanks.

How did we function before without reliable, speedy builds?

@Be-ing Be-ing merged commit 46337b9 into mixxxdj:2.3 Mar 9, 2021
@uklotzde uklotzde deleted the soundsourcemediafoundation branch March 17, 2021 17:56
This was referenced Aug 23, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Awaiting requested review from Be-ing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@uklotzde @Be-ing