Do not save missing tracks to prevent inconsistent metadata #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metadata of tracks in the database should not be modified as long as they are missing to prevent inconsistencies with the file metadata. This will become an issue soon. Other changes: - Return more meaningful results when saving tracks - Perform checks behind the internal API in TrackCollectionManager and use debug assertions in TrackDAO
|
Makes sense. Should this go into 2.3? |
No. It is not an issue yet and would cause merge conflicts. Main has already advanced in track management. |
|
One edge case is that you edit track properties and then unmount the drive with the track file before the track has been saved. Unfortunately, synchronizing the genre/mood tag with custom tags causes tracks to become dirty without manual editing. This could happen with any data migration that is performed lazily at runtime. Better be restrictive and discard pending changes in this rare edge case instead of risking inconsistencies. |
daschuer
reviewed
May 1, 2021
|
Thank you. |
daschuer
added a commit
to daschuer/mixxx
that referenced
this pull request
Aug 18, 2021
Co-authored-by: Jan Holthuis <holthuis.jan@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata of tracks in the database should not be modified as long as they are missing to prevent inconsistencies with the file metadata. This will become an issue soon (when synchronizing custom genre/mood tags with metadata).
Other changes: