Delete leaking controls #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| delete m_pControlVinylStatus; | ||
| delete m_pControlVinylSpeedType; | ||
| delete m_pControlVinylSeek; |
There was a problem hiding this comment.
might as well make these alphabetical
There was a problem hiding this comment.
I put them in the same order that they were initialized in the constructor. Is alphabetically preferable?
There was a problem hiding this comment.
the official googley style is to destruct things in reverse order of construction (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Static_and_Global_Variables#Static_and_Global_Variables)
…ction order (following google style guidelines).
|
I'm going to move these changes to another branch with typos and improvements to general mixxx code I've found during GSoC, which I will merge at the end of the summer. |
|
If they are all minor fixes and corrections, there's no reason not to merge them right away. |
Merged
11 tasks
ronso0
referenced
this pull request
in ronso0/mixxx
Nov 6, 2019
add "Aux not configured" warning popup
m0dB
pushed a commit
to m0dB/mixxx
that referenced
this pull request
Jan 21, 2024
Make website responsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the shutdown command line output I found all leaking controls that I could delete and added deletion code in the relevant destructor methods. The leaking flanger controls are a special case, so I didn't bother figuring them out right now, but I fixed all of the other leaking controls.