Changed ControlObjectThreadMain instances to ControlObjectThread where no direct connection is used. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no direct connection is used.
ControlObjectThread if no direct connection is used.
ControlObjectThread where no direct connection is used.
| pHeadphones->slotSet(defaultHeadphones); | ||
| delete pHeadphones; | ||
| ControlObject::set(ConfigKey(getGroup(), "master"), (double)defaultMaster); | ||
| ControlObject::set(ConfigKey(getGroup(), "pfl"), (double)defaultHeadphones); |
There was a problem hiding this comment.
saves memory allocation.
|
This patch is starting to rod. I would like to have a second pair of eyes to confirm my changes. |
| @@ -30,16 +23,16 @@ bool WaveformMarkRange::active() { | |||
|
|
|||
| bool WaveformMarkRange::enabled() { | |||
| // Default to enabled if there is no enabled control. | |||
| return m_markEnabledControl == NULL || | |||
There was a problem hiding this comment.
If setup() is not called yet, this will segfault. Shouldn't the NULL check stay (for enabled(), start() and end()) as a safety?
|
LGTM other than my comment about WaveformMarkRange. Thank you! |
Conflicts: src/dlgprefcontrols.cpp src/dlgprefrecord.cpp src/dlgprefrecord.h src/widget/wnumberpos.h
|
Thank you for review! |
daschuer
added a commit
that referenced
this pull request
Oct 11, 2013
Changed ControlObjectThreadMain instances to ControlObjectThread where no direct connection is used.
Merged
11 tasks
ronso0
referenced
this pull request
in ronso0/mixxx
Nov 6, 2019
implement Aux,master in skins, hide unconfigured Mic units
ronso0
referenced
this pull request
in ronso0/mixxx
May 14, 2020
put Cue Shift buttons below CurPos button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our previous discussion ControlObjectThreadMain ensures that the valueChanged signals are propagated by the Main Thread. This makes a different, when Qt::DirectConnection is used in the using code.
I have checked all occurrences of ControlObjectThreadMain and changed them to ControlObjectThread if no direct connection is used. Most of them does not use any connection. So we save a unnecessary round trip thought the Qt event queue.
If my other refactoring branch #38 is accepted, we can change most (or all) of them to ControlObjectSlave. This will save some direct connected function calls ass well because it is optimized for no connection.