Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metainfo fixes #4349

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Metainfo fixes #4349

merged 2 commits into from
Oct 4, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Oct 2, 2021

See commit messages for details.

Before this commit, appstream-util fails to validate this document due
the following error:

    $ appstream-util validate-relax res/linux/org.mixxx.Mixxx.metainfo.xml
    res/linux/org.mixxx.Mixxx.metainfo.xml: failed to parse res/linux/org.mixxx.Mixxx.metainfo.xml: Error on line 267 char 5: <li> already set 'It is no longer necessary to manually copy the udev rule file in packaging scripts. Now pkg-config is used to determine the udevdir used to install the rules file in the CMake install step when CMAKE_INSTALL_PREFIX is' and tried to replace with '
       or
       '
Fixes the following appstream-util validation errors:

    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-palemoon-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-palemoon-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/deere-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/deere-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-classic-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-classic-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-classic-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-classic-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-dark-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-dark-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-summersunset-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-summersunset-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/tango-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/tango-3840x2160.png] maximum is 900px
@Holzhaus
Copy link
Member Author

Holzhaus commented Oct 2, 2021

The second commit depends on mixxxdj/website#260.

@Holzhaus Holzhaus marked this pull request as draft October 2, 2021 23:12
@Holzhaus Holzhaus marked this pull request as ready for review October 4, 2021 22:30
@Be-ing Be-ing merged commit e086cdd into mixxxdj:2.3 Oct 4, 2021
@Holzhaus Holzhaus added this to the 2.3.2 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants