Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metainfo fixes #4349

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Metainfo fixes #4349

merged 2 commits into from
Oct 4, 2021

Commits on Oct 2, 2021

  1. metainfo.xml: Remove <code> tags to avoid appstream-util parser errors 

    Before this commit, appstream-util fails to validate this document due
the following error:

    $ appstream-util validate-relax res/linux/org.mixxx.Mixxx.metainfo.xml
    res/linux/org.mixxx.Mixxx.metainfo.xml: failed to parse res/linux/org.mixxx.Mixxx.metainfo.xml: Error on line 267 char 5: <li> already set 'It is no longer necessary to manually copy the udev rule file in packaging scripts. Now pkg-config is used to determine the udevdir used to install the rules file in the CMake install step when CMAKE_INSTALL_PREFIX is' and tried to replace with '
       or
       '
    @Holzhaus
    Holzhaus committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    3268946 View commit details
    Browse the repository at this point in the history

  2. metainfo.xml: Use 1600x1200px screenshots 

    Fixes the following appstream-util validation errors:

    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-palemoon-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-palemoon-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/deere-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/deere-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-classic-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/latenight-classic-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-classic-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-classic-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-dark-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-dark-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/shade-summersunset-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/shade-summersunset-3840x2160.png] maximum is 900px
    • attribute-invalid     : <screenshot> width too large [https://mixxx.org/theme/images/2.3/screenshots/tango-3840x2160.png] maximum is 1600px
    • attribute-invalid     : <screenshot> height too large [https://mixxx.org/theme/images/2.3/screenshots/tango-3840x2160.png] maximum is 900px
    @Holzhaus
    Holzhaus committed Oct 2, 2021
    Configuration menu
    Copy the full SHA
    fe305e4 View commit details
    Browse the repository at this point in the history