lp1445885: Detect MIME type and deduce expected file extension and type #4356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking only the actual file extension is not sufficient. Fixes: https://bugs.launchpad.net/mixxx/+bug/1445885
Holzhaus
approved these changes
Oct 5, 2021
|
Thank you! |
|
This deserves a changelog entry IMHO. @uklotzde could you add one? |
|
I forgot to consider uppercase suffixes. Fix and changelog entry will follow. |
Wouldn't that just be another instance of "unknown suffix"? |
|
Sure, but the warnings in the log are misleading and confusing. And the test fails for missing files or unknown MIME types where only the suffix is available. |
This was referenced Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking only the actual file extension is not sufficient.
Fixes: https://bugs.launchpad.net/mixxx/+bug/1445885