Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type detection of AIFF files #4364

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Fix type detection of AIFF files #4364

merged 2 commits into from
Oct 10, 2021

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented Oct 7, 2021 •
edited
Loading

Another follow-up of #4356. The file type mapping of AIFF files was already inconsistent before.

  • Consistently map to file type "aiff", even if the file suffix is ".aif"
  • Fix existing database entries

@Holzhaus
Copy link
Member

Holzhaus commented Oct 7, 2021

Thanks. Does this need to be backported to 2.3?

@uklotzde
Copy link
Contributor Author

uklotzde commented Oct 7, 2021 •
edited
Loading

Thanks. Does this need to be backported to 2.3?

No. Let's leave it as is as long as no one complains. The inconsistencies have not been introduced by the latest changes.

Be-ing
Be-ing reviewed Oct 9, 2021
View reviewed changes
src/test/soundproxy_test.cpp Outdated Show resolved Hide resolved
Be-ing
Be-ing approved these changes Oct 9, 2021
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable change to me though it'd be nice to have a review from someone more familiar with this area of the code

@Be-ing Be-ing merged commit fbaafb4 into mixxxdj:main Oct 10, 2021
@uklotzde uklotzde deleted the soundsource-aiff branch October 10, 2021 10:08
@uklotzde uklotzde mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
code quality minor bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uklotzde @Holzhaus @Be-ing