midi-components-0.0.js: Add JogWheel component #4474

Swiftb0y · 2021-10-23T11:14:32Z

Introduces a component intended to be mapped to the standard
jogwheel encoder + touch sensitive surface combo present on
most controllers nowadays.

I'm targeting 2.3 because I'm planning to use the component for a 2.3 mapping.

Be-ing · 2021-10-23T13:13:00Z

res/controllers/midi-components-0.0.js

+            if (engine.isScratching(this.deck)) {
+                engine.scratchTick(this.deck, value);
+            } else {
+                this.inSetValue(value);
+            }


This assumes a 1 : 1 correspondence between scratchTick values and jog values. Is this appropriate for all hardware?

true, maybe this.inSetParameter(this.inValueScale(value)); is more appropriate? I don't really know what scales jog is even supposed to be used with.

I don't really know what scales jog is even supposed to be used with.

Does anyone?

Our docs even say "jog" is deprecated?!

Deprecated since version ??: Use the JavaScript engine.scratch functions instead.

Is that even true?

In general, I'd say that the ticks per rotation are somewhat proportional to the physical wheel size. I'd say this is fine for now. If you disagree, I could add a jog scaling factor to the component to make this tweakable if it really needs to.

I'd say this is a decent stop-gap solution and usable wrapper in case we ever decide to change the CO API.

"jog" and "wheel" control objects have varying amounts of magic to try to get them to work well, like magic numbers that multiply their values depending on play/pause status. I always end up needing to adjust these parameters in my javascript anyway. People still use them because they are easy to write for -- the jog CO has a built-in filter to smooth out and decay values.

I would say the jog control is ok to use for a first implementation, but it would be nice to move the filtering / processing code out of C++ (it's in ratecontrol.cpp and rotary.cpp) and into javascript to drive the scratch2 parameter instead. That could be done in a followup.

I would not worry about relying on "jog" here -- it may be "deprecated" or not preferred, but that code is not going anywhere.

True, but this misses the point a bit. The point of introducing this JogWheel component was to add an abstraction around our COs, so most users don't have to deal with the quirks of the current system and can just map the input handlers without having to worry about the details in most cases.

Yes, but you asked whether the jog CO was deprecated, so I thought it might be useful to have some background / context information.

well, whatever it currently is, we should probably clarify it in the manual then because it says Use the JavaScript engine.scratch functions instead. there

Swiftb0y · 2021-11-08T19:47:01Z

friendly ping ;)

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474 and mixxxdj#4495

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

github-actions · 2022-02-07T00:34:03Z

This PR is marked as stale because it has been open 90 days with no activity.

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

Swiftb0y · 2022-03-23T20:16:15Z

Another friendly ping....
This code is simple to review and maintain and a worthwhile abstraction to offer...

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

ronso0 · 2022-05-29T20:07:00Z

ping @Be-ing and @ywwg ?

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

ywwg · 2022-07-06T13:32:12Z

I will take a look at this!

res/controllers/midi-components-0.0.js

Swiftb0y · 2022-07-06T14:33:37Z

Thank you @ywwg for taking the time to review this long-standing PR.

Swiftb0y · 2022-07-09T14:10:20Z

done

Swiftb0y · 2022-07-09T14:15:34Z

Sorry I had to rebase on a newer 2.3 commit to fix the failing pre-commit hooks.

ywwg

Thank you for doing this! Do you want to work on the clock-based jogwheel component next? I am happy to guide / review that.

Please merge at your leisure once you've fixed any conflicts etc.

Swiftb0y · 2022-07-10T14:57:55Z

Do you want to work on the clock-based jogwheel component next?

Not yet really. This PR had priority for me because its a prerequisite for #4513. Also I don't really know how the scratch2-based implementation is really supposed to work. I'd much rather review any PR from you in this case.

Thank you for doing this!

Thank you for finally reviewing this. I kinda lost hope. I'd really appreciate if you could take a look at #4513 next since that is also way overdue (also its a fairly idiomatic ComponentsJS-based implementation so I think the required review work should be minimal).

Introduces a component intended to be mapped to the standard jogwheel encoder + touch sensitive surface combo present on most controllers nowadays. Co-authored-by: Owen Williams <owen-github@ywwg.com>

Swiftb0y · 2022-07-10T15:33:26Z

Added wiki entry https://github.com/mixxxdj/mixxx/wiki/Components-JS#jogwheelbasic

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

Initial commit of a mapping for the Reloop Ready controller. The Padmodes are not implemented and just default to the hotcues right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512 fix(controllers): Reloop Ready fx2 level knob Co-authored-by: majekw <majek@w7i.pl> various features (i'll squash later anyways) * Add option to correct for offset tempo fader notches * Improve LED feedback of various buttons when pressing and shifting * add eject function to load button when shift-pressing * remove dad code * turn of big pads when shutting down * fix 4th pad in ManualLoopPadMode (loop_in_goto) * Add beatJumpMode for ScratchBank * fix slip button Add pitch play mode (WIP) (untested)

Swiftb0y requested a review from Be-ing October 23, 2021 11:14

github-actions bot added the controller mappings label Oct 23, 2021

Be-ing reviewed Oct 23, 2021

View reviewed changes

Swiftb0y mentioned this pull request Nov 10, 2021

Controllers: Add Mapping for Reloop Ready #4513

Draft

github-actions bot added the stale Stale issues that haven't been updated for a long time. label Feb 7, 2022

github-actions bot removed the stale Stale issues that haven't been updated for a long time. label Mar 24, 2022

Swiftb0y added the needs review label Jun 9, 2022

ywwg requested changes Jul 6, 2022

View reviewed changes

res/controllers/midi-components-0.0.js Outdated Show resolved Hide resolved

res/controllers/midi-components-0.0.js Outdated Show resolved Hide resolved

Swiftb0y force-pushed the components-jogwheel branch 2 times, most recently from d1a877b to 6001b21 Compare July 9, 2022 14:09

Swiftb0y force-pushed the components-jogwheel branch from 6001b21 to e0b5c79 Compare July 9, 2022 14:13

ywwg approved these changes Jul 10, 2022

View reviewed changes

midi-components-0.0.js: Add JogWheel component

8d60978

Introduces a component intended to be mapped to the standard jogwheel encoder + touch sensitive surface combo present on most controllers nowadays. Co-authored-by: Owen Williams <owen-github@ywwg.com>

Swiftb0y force-pushed the components-jogwheel branch from e0b5c79 to 8d60978 Compare July 10, 2022 15:06

Swiftb0y merged commit 6dea2f3 into mixxxdj:2.3 Jul 10, 2022

Swiftb0y deleted the components-jogwheel branch January 9, 2023 10:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

midi-components-0.0.js: Add JogWheel component #4474

midi-components-0.0.js: Add JogWheel component #4474

Swiftb0y commented Oct 23, 2021

Be-ing Oct 23, 2021

Swiftb0y Oct 23, 2021

Be-ing Oct 23, 2021

Swiftb0y Oct 23, 2021

Swiftb0y Oct 23, 2021

Swiftb0y Oct 23, 2021

ywwg Oct 26, 2021

Swiftb0y Oct 26, 2021

ywwg Nov 1, 2021

Swiftb0y Nov 1, 2021

Swiftb0y commented Nov 8, 2021

github-actions bot commented Feb 7, 2022

Swiftb0y commented Mar 23, 2022

ronso0 commented May 29, 2022

ywwg commented Jul 6, 2022

Swiftb0y commented Jul 6, 2022

Swiftb0y commented Jul 9, 2022

Swiftb0y commented Jul 9, 2022

ywwg left a comment

Swiftb0y commented Jul 10, 2022

Swiftb0y commented Jul 10, 2022 •

edited

Loading

midi-components-0.0.js: Add JogWheel component #4474

midi-components-0.0.js: Add JogWheel component #4474

Conversation

Swiftb0y commented Oct 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Swiftb0y commented Nov 8, 2021

github-actions bot commented Feb 7, 2022

Swiftb0y commented Mar 23, 2022

ronso0 commented May 29, 2022

ywwg commented Jul 6, 2022

Swiftb0y commented Jul 6, 2022

Swiftb0y commented Jul 9, 2022

Swiftb0y commented Jul 9, 2022

ywwg left a comment

Choose a reason for hiding this comment

Swiftb0y commented Jul 10, 2022

Swiftb0y commented Jul 10, 2022 • edited Loading

Swiftb0y commented Jul 10, 2022 •

edited

Loading