Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.eslintrc.json: adjust eslint rules to enforce readable chain syntax #4512

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

Swiftb0y
Copy link
Member

previously, the eslint hook would enforce that the dot of multi-
line chaining was attached to the object instead of the property
thus formatting the first example into the second which I
find less readable.

const a = _({})
    .mapKeys(...)
    .filter(...)
    .value();
const a = _({}).
    mapKeys(...).
    filter(...).
    value();

previously, the eslint hook would enforce that the dot of multi-
line chaining was attached to the object instead of the property
thus formatting the first example into the second which I
find less readable.

```javascript
const a = _({})
    .mapKeys(...)
    .filter(...)
    .value();
```
```javascript
const a = _({}).
    mapKeys(...).
    filter(...).
    value();
```
@Swiftb0y Swiftb0y changed the base branch from main to 2.3 November 10, 2021 18:26
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Nov 10, 2021
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Nov 10, 2021
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
@Holzhaus Holzhaus merged commit 44accaf into mixxxdj:2.3 Nov 10, 2021
@Swiftb0y Swiftb0y deleted the eslint-chained-method-calls branch November 10, 2021 20:32
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jan 12, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jan 20, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Mar 20, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Mar 23, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Mar 24, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jun 9, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jul 25, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jul 25, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Jul 28, 2022
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512
Swiftb0y added a commit to Swiftb0y/mixxx that referenced this pull request Feb 15, 2024
Initial commit of a mapping for the Reloop Ready controller.
The Padmodes are not implemented and just default to the hotcues
right now. The mapping currently depends on mixxxdj#4474, mixxxdj#4495 and mixxxdj#4512

fix(controllers): Reloop Ready fx2 level knob

Co-authored-by: majekw <majek@w7i.pl>

various features (i'll squash later anyways)

* Add option to correct for offset tempo fader notches
* Improve LED feedback of various buttons when pressing and shifting
* add eject function to load button when shift-pressing
* remove dad code
* turn of big pads when shutting down
* fix 4th pad in ManualLoopPadMode (loop_in_goto)
* Add beatJumpMode for ScratchBank
* fix slip button

Add pitch play mode (WIP) (untested)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants