Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge yet] Upgrade vendored libhidapi to v0.12.0 #4779

Closed
wants to merge 4 commits into from
Closed

[Don't merge yet] Upgrade vendored libhidapi to v0.12.0 #4779

wants to merge 4 commits into from

Conversation

uklotzde
Copy link
Contributor

@uklotzde uklotzde commented May 31, 2022

Accompanying pull request for #4777:

  • Stripped down our vendored version of libhidapi to the minimum
  • Extended .gitignore (ready for uprade to v0.12.0)
  • Upgraded libhidapi to v0.12.0
  • Final commit: Increased minimum required version to 0.12.0 for testing purposes to enforce building the vendored version on all platforms

Separating all tasks into individual commits ensures that the .gitignore changes do not introduce any conflicts and inconsistencies with existing files in the repo!

The first 3 commits could serve as a new base for #4777.

@github-actions github-actions bot added the build label May 31, 2022
@uklotzde uklotzde changed the title Clean upgrade to libhidapi v0.12.0 [Don't merge] Clean upgrade to libhidapi v0.12.0 May 31, 2022
@uklotzde uklotzde changed the title [Don't merge] Clean upgrade to libhidapi v0.12.0 [Don't merge] Upgrade vendored libhidapi to v0.12.0 May 31, 2022
@uklotzde uklotzde changed the title [Don't merge] Upgrade vendored libhidapi to v0.12.0 [Don't merge yet] Upgrade vendored libhidapi to v0.12.0 May 31, 2022
@uklotzde
Copy link
Contributor Author

The previous failure on Windows demonstrated that the files are actually used in the build ;) Next try.

@uklotzde
Copy link
Contributor Author

@JoergAtGithub Please rebase your custom changes from #4777 (i.e. everything that does not affect lib/hidadpi and .gitignore) on the first 3 commits of this branch/PR. Preserve the original branch name and then force push to keep #4777 alive.
@Holzhaus Do you agree?

@uklotzde uklotzde closed this May 31, 2022
@uklotzde uklotzde deleted the strip-lib-hidapi branch July 3, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant