Update hidapi to 0.12.0 #4777
Update hidapi to 0.12.0 #4777
Conversation
|
Thanks. Could you remove the CI and documentation files from this PR and potentially add them as a gitignore pattern to avoid accidental commits in the future? |
Please strip the archive down to the minimum as before, only required sources and license files. |
|
The commits should be squashed. |
JoergAtGithub
force-pushed
the
hidapi_0.12.0
branch
from
d8b5cf5
to
d93fa07
Compare
|
Can you squash all commits again, to remove the not used files entirely from the git history. Thanks. |
Delete unused files from lib/hidapi Updated hidapi from 0.10.1 to 0.12.0 Increased minimum required hidapi version to 0.11.2
JoergAtGithub
force-pushed
the
hidapi_0.12.0
branch
from
f7aa9f3
to
6684df7
Compare
|
Why is this still being vendored? IIRC it was in the past due to an old version in Ubuntu? |
|
focal (20.04LTS) 0.9.0+dfsg-1 Even fedora 36 is on 0.11.2 |
|
If we only need a safety net for our minimum required version, we may only update to 0.11.2. than we have the chance to remove the vendored library once we drop support for focal / impish / |
|
I don't have a strong opinion here. Without lifting the requirement to 0.12, aged distros will build with 0.12 and the recent versions with 0.11. Is this desired? |
There was a problem hiding this comment.
I think before merge we should either lift the minimum requirements to 0.12 or downgrade the overlay to 0.11. that everything is consistent.
Do the 0.12 changes outwaight the regression risk of using a 7 days old library no one else is using (yet) ?
@uklotzde what do you think about this?
I don't care. But let's please stop these back and forth edits. |
|
For now I think it is best to downgrade to 0.11. Sorry for the extra loop. I have original missed the missmatch between the required and the installed version. |
This PR updates hidapi to the latest version 0.12.0
Furthermore it increases the minimum required version to 0.11.2. This solves the open FIXME of #4054. Since this PR getInputReport is no longer working on Linux, because the hidapi command hid_get_input_report wasn't implemented for the Linux hidraw backend at this time.
This was fixed by libusb/hidapi#259 which was part of the hidapi 0.11.2 release.
Note: hid_get_input_report will only succeed with Linux Kernel 5.11 or later. With earlier Linux kernel versions, hid_get_input_report will return error code -1 as before this PR.