Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hidapi to 0.11.2 #4783

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Update hidapi to 0.11.2 #4783

merged 1 commit into from
Jun 5, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Jun 1, 2022

This is #4777 downgraded to 0.11.2 to match the minimum requirement only.
This will allow to remove this overlay one day.

We can merge this either directly or @JoergAtGithub can reset his branch to this.

Delete unused files from lib/hidapi
Updated hidapi from 0.10.1 to 0.11.2
Increased minimum required hidapi version to 0.11.2
@github-actions github-actions bot added the build label Jun 1, 2022
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is at least a step in the right direction. LGTM

@uklotzde
Copy link
Contributor

uklotzde commented Jun 5, 2022

Wait, this should go into 2.3!

@uklotzde uklotzde changed the base branch from main to 2.3 June 5, 2022 20:21
@uklotzde uklotzde changed the base branch from 2.3 to main June 5, 2022 20:22
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on 2.3 and retarget.

@daschuer daschuer changed the base branch from main to 2.3 June 5, 2022 20:53
@daschuer
Copy link
Member Author

daschuer commented Jun 5, 2022

Done

@JoergAtGithub
Copy link
Member

It's not neccessary, to raise the required hidapi version in CMakeLists.txt for 2.3.
Neither hid_get_input_report nor the hidraw backend for Linux is used in 2.3.

@daschuer
Copy link
Member Author

daschuer commented Jun 5, 2022

OK so I will revert the rebase. It is better to not touch the stable version if not necessary.

@uklotzde uklotzde merged commit 4e90c68 into mixxxdj:main Jun 5, 2022
@daschuer daschuer deleted the hidapi_11 branch October 12, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants