-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update hidapi to 0.11.2 #4783
Update hidapi to 0.11.2 #4783
Conversation
Delete unused files from lib/hidapi Updated hidapi from 0.10.1 to 0.11.2 Increased minimum required hidapi version to 0.11.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is at least a step in the right direction. LGTM
Wait, this should go into 2.3! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on 2.3 and retarget.
Done |
It's not neccessary, to raise the required hidapi version in CMakeLists.txt for 2.3. |
OK so I will revert the rebase. It is better to not touch the stable version if not necessary. |
This is #4777 downgraded to 0.11.2 to match the minimum requirement only.
This will allow to remove this overlay one day.
We can merge this either directly or @JoergAtGithub can reset his branch to this.