-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos qt drag and drop fix #46
Conversation
I have filed https://bugs.launchpad.net/mixxx/+bug/1978384 for this, before I saw that you already looked into this. Thanks! Since we won't get around patching the Qt build in the Intel version either now, we could probably upstream the M1 patches, even if Mixxx doesn't choose to officially provide binaries for ARM macOS, right? |
4427046
to
4114e11
Compare
Yes, but lets go in steps. |
I can confirm that the drag-n-drop patch works as expected (with the minor caveat that drag ghost images always seem to appear in the window's top left corner when dragging multiple tracks, this does not impact the actual functionality though and should not block the PR). |
Nice news, thank you. |
@Swiftb0y: can you have a brief look here? We may merge this at one or the clean up PR first. This one applies upstream patches from QT 5.15 |
948edea
to
8ff871a
Compare
8ff871a
to
c46931b
Compare
@Swiftb0y This is now rebased to 2.4, ready for review. |
Thank you. I don't quite understand what I'm looking at though. The two patch files, where did they originate from? |
They are taken form here: |
Ok thanks for clarifying. |
This aims to fix the drag and drop issue reported here: mixxxdj/mixxx#4717
This PR is on top of #45