Fix for 596 #605
Merged
Fix for 596 #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging updates.
merge main into fork
Merge with master
Merge with master
merge with master
Bugfix tvp type mismatch
|
I ran into #596 as well. I was glad to see that this is in work! Thank you. I was using the test_tvp code to track down the problem before I found this ticket. Would adding a None/NULL input to the test_tvp be helpful here? Perhaps changing c05 to [1, 0, None]? |
|
Glad to see this has been fixed. Will this pull request be merged any time soon? |
|
I still see the issue if we have None in the first row. ('HY004', '[HY004] [Microsoft][SQL Server Native Client 11.0]Invalid SQL data type (0) (SQLBindParameter) |
I am also facing this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#596
I tried this with the repro app, and ran the sqlserver tests, everything seems to work OK