Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floatTheader breaks if <thead> element has multiple rows #29

Closed
ghost opened this issue Dec 19, 2013 · 12 comments
Closed

floatTheader breaks if <thead> element has multiple rows #29

ghost opened this issue Dec 19, 2013 · 12 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 19, 2013

If the table has multiple rows in the header:

eg

<thead>
  <tr>
     (the title of the table)
  </tr>
  <tr>
     (the column headers in multiple <th>
  </tr>
</thead>

This plugin breaks - what if we want to include the column headers as part of the scrollable part along with the table title?

@mkoryak
Copy link
Owner

mkoryak commented Dec 19, 2013

aha! edited your question and found some html in there that was not syntax highlighted - now it makes a bit more sense. Will look into it

@mkoryak
Copy link
Owner

mkoryak commented Dec 23, 2013

You are going to have to be a bit more specific about your html. Here is a test case that shows a multiple rows in the header working (for me in chrome):

http://jsfiddle.net/P8GFy/

and

http://jsfiddle.net/P8GFy/1/

@ghost
Copy link
Author

ghost commented Dec 23, 2013

Never mind -- we got it to work. So it turns out that one of the rows in
our header had element in it, and that broke it. We changed it to
and it worked.

On Sun, Dec 22, 2013 at 9:03 PM, Misha Koryak notifications@gh.neting.ccwrote:

You are going to have to be a bit more specific about your html. Here is a
test case that shows a multiple rows in the header working (for me in
chrome):

http://jsfiddle.net/P8GFy/

and

http://jsfiddle.net/P8GFy/1/


Reply to this email directly or view it on GitHubhttps://github.com//issues/29#issuecomment-31104539
.

@casey6
Copy link

casey6 commented Sep 29, 2015

Your examples don't seem to be working in IE.

@mkoryak
Copy link
Owner

mkoryak commented Sep 29, 2015

they actually dont work in any browser. I broke it at some point, thanks for reminding me about this.

@mkoryak mkoryak reopened this Sep 29, 2015
@mkoryak
Copy link
Owner

mkoryak commented Sep 29, 2015

err, you reminded me about a different issue. this should work. What version of IE do you use?

@casey6
Copy link

casey6 commented Sep 29, 2015

In IE11 it's not working for me.

@mkoryak
Copy link
Owner

mkoryak commented Sep 29, 2015

it looks like an issue with jsfiddle, it shows these cross domain errors on the console:

SCRIPT5: Access is denied.

File: jquery-2.0.2.js, Line: 1378, Column: 2
SCRIPT5009: 'jQuery' is undefined
File: jquery.floatThead.js, Line: 15, Column: 2
SCRIPT5009: '$' is undefined
File: _display, Line: 29, Column: 1

I have no idea what thats about, probably IE11 sucking

@casey6
Copy link

casey6 commented Sep 29, 2015

That example works for you in IE11? It does not for me.

http://i.imgur.com/aO1Oabi.png

@mkoryak
Copy link
Owner

mkoryak commented Sep 29, 2015

no, it doesnt work, but look at the console. it cant find jquery, yet jquery is on the page (or so it claims)

@mkoryak
Copy link
Owner

mkoryak commented Sep 29, 2015

here we go, using an ancient version of jquery makes it work:
http://jsfiddle.net/P8GFy/6/

@lock
Copy link

lock bot commented Dec 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants