Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floadThead 1.2.5 not works with Bootstrap 3 tabs #71

Closed
Grey2k opened this issue Mar 27, 2014 · 7 comments
Closed

floadThead 1.2.5 not works with Bootstrap 3 tabs #71

Grey2k opened this issue Mar 27, 2014 · 7 comments
Labels

Comments

@Grey2k
Copy link

Grey2k commented Mar 27, 2014

Hi. thanks for your project =)

In version 1.2.1 - i use you plugin with tabs and has table in for example two different tab.

after switching floatThead need to be destroy and init, cause was some incorrect width calculation, but ins ok - i use tab shown event and make this hack on callback

but now i try to update to 1.2.5 and here after i switch the tab floatThead delete thead element from DOM. and after i click my tab again a had error.

jQuery.floatThead must be run on a table that contains a element

i think its a bug, and you can resolve it.

@mkoryak
Copy link
Owner

mkoryak commented Mar 27, 2014

Hi,
Can you please provide a jsfiddle where this bug can be reproduced? Also, if it is helpful you can type in russian :)

@Grey2k
Copy link
Author

Grey2k commented Mar 27, 2014

Спасибо ) ок, подготовлю пример

@mkoryak
Copy link
Owner

mkoryak commented Mar 28, 2014

I was able to reproduce your issue on one of my demo pages, no fiddle will be necessary.
Ill see if I can get it fix this weekend or early next week.

@mkoryak
Copy link
Owner

mkoryak commented Mar 31, 2014

I did it once, and now i cant reproduce any more. If you can get a jsfiddle it will help. Otherwise ill try to figure out what I did / or try to fix it blindly.

@mkoryak
Copy link
Owner

mkoryak commented Mar 31, 2014

Sorry, that commit is not a fix for this issue. I made a mistake in the commit message.

@mkoryak mkoryak added the bug label Apr 3, 2014
@mkoryak mkoryak closed this as completed in 4d249da Apr 8, 2014
mkoryak added a commit that referenced this issue Apr 8, 2014
* origin/v1.2.6:
  ooops, this is the issue this fixes #70
  fix #71 - setting table to width auto is not actually as good as letting the width be whatever it should be via css (that we dont know about)
@mkoryak mkoryak reopened this Apr 9, 2014
mkoryak added a commit that referenced this issue Apr 10, 2014
…and if you destroyed enough widgets, strange things would start happening.
@mkoryak
Copy link
Owner

mkoryak commented Apr 11, 2014

this issue is fixed on master and will be pushed as v1.2.6

@mkoryak mkoryak closed this as completed Apr 11, 2014
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants