Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header height and hidden TR #86

Closed
eric-void opened this issue May 16, 2014 · 5 comments
Closed

Header height and hidden TR #86

eric-void opened this issue May 16, 2014 · 5 comments
Assignees

Comments

@eric-void
Copy link

In function setHeaderHeight you do this code:

        $header.find("tr").each(function(){
          headerHeight += $(this).outerHeight(true);
        });

This code consider hidden tr as well. This should be better:

        $header.find("tr:visible").each(function(){
          headerHeight += $(this).outerHeight(true);
        });
@mkoryak mkoryak self-assigned this May 16, 2014
@mkoryak
Copy link
Owner

mkoryak commented May 19, 2014

but if its hidden it has no height, so it shouldn't make a difference.

@eric-void
Copy link
Author

That's not true (at least in my jquery on firefox). I've a TR with "display: none" (but with content inside, obviously not visibile) and if i make a $(tr).height() jquery gives me the height of the content... if you don't see the same beahavious i'll try to do a jsfiddle.

@mkoryak
Copy link
Owner

mkoryak commented Jun 30, 2014

fiddle: http://jsfiddle.net/DxX2T/31/

@mkoryak
Copy link
Owner

mkoryak commented Jun 30, 2014

fixed in v1.2.8

@mkoryak mkoryak closed this as completed Jul 7, 2014
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants