Migrate CI to github actions #2
Conversation
Did you mean to GitHub Actions? |
|
So the big change is the pipeline was converted to GitHub Actions (what was it before that?) Also some minor code/import changes to make sure the pipeline succeeds? If so LGTM |
| async def aiohttp_all_auth(token_info): | ||
| return await aiohttp_token_info(token_info) | ||
|
|
||
|
|
||
| async def aiohttp_async_auth(token_info): | ||
| return await aiohttp_token_info(token_info) | ||
|
|
||
|
|
||
| async def aiohttp_bearer_auth(token_info): | ||
| return await aiohttp_token_info(token_info) | ||
|
|
||
|
|
||
| async def aiohttp_async_bearer_auth(token_info): | ||
| return await aiohttp_token_info(token_info) | ||
|
|
||
|
|
There was a problem hiding this comment.
What is this solving?
Should all of these be async or only the ones with async in the name?
There was a problem hiding this comment.
The operationId in the OpenAPI spec needs to be unique to be valid. Connexion uses the operationId to link to the Python code that needs to be executed. Previously all endpoints in tests/fixtures/aiohttp/openapi_secure.yaml pointed to the same Python function which led to validation errors of the spec, so I decoupled this into separate functions.
RobbeSneyders
force-pushed
the
feature/travis-to-gh-actions
branch
from
9a2370f
to
f005522
Compare
|
Sorry for the late comment. I think you forgot to remove |
This PR moves the CI pipeline from the Zalando's Travis CI to github actions so it can run on this repository.
Since no upper limits were defined for the dependencies, the pipeline was broken and I had to implement some fixes first. I added upper limits for the dependencies to prevent external changes from breaking Connexion in the future.