-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move CICD from Travis to Github Actions #1367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have one suggestion.
pip install --upgrade pip | ||
pip install tox tox-gh-actions setuptools coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think would be nice if we considered to pin those versions. Those packages may release major versions with breaking changes that can break Connexion CI/CD pipeline in an unfortunate moment. I know we have more maintainers now, but if we have multiple PRs, we need to coordinate with external contributors to ask them to rebase their PRs or commit to each PR to fix the pipeline. It might be wise to just pin the versions here and avoid the headache. We can still update the versions whenever we need, of course.
👍 |
This PR moves CICD from Travis to Github Actions as discussed in #1365.
It also fixes some issues currently breaking the pipeline
These changes are a combination of the following PRs on the ML6 fork with some small adaptations: