Move CICD from Travis to Github Actions #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbeSneyders
requested review from
rafaelcaricio,
hjacobs,
dtkav,
jmcs and
Ruwann
rafaelcaricio
approved these changes
Jun 25, 2021
Comment on lines
+21
to
+22
| pip install --upgrade pip | ||
| pip install tox tox-gh-actions setuptools coveralls |
There was a problem hiding this comment.
I think would be nice if we considered to pin those versions. Those packages may release major versions with breaking changes that can break Connexion CI/CD pipeline in an unfortunate moment. I know we have more maintainers now, but if we have multiple PRs, we need to coordinate with external contributors to ask them to rebase their PRs or commit to each PR to fix the pipeline. It might be wise to just pin the versions here and avoid the headache. We can still update the versions whenever we need, of course.
|
👍 |
hjacobs
approved these changes
Jun 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves CICD from Travis to Github Actions as discussed in #1365.
It also fixes some issues currently breaking the pipeline
These changes are a combination of the following PRs on the ML6 fork with some small adaptations: