rewrite norm

mljs · Sep 20, 2023 · 62f6575 · 62f6575
1 parent c0cfbf1
commit 62f6575
Showing 1 changed file with 7 additions and 13 deletions.
diff --git a/src/matrix.js b/src/matrix.js
@@ -803,19 +803,13 @@ export class AbstractMatrix {
   }
 
   norm(type) {
-    if (type === undefined) type = 'frobenius';
-    let result = 0;
-    if (type === 'max') {
-      return this.max();
-    } else if (type === 'frobenius') {
-      for (let i = 0; i < this.rows; i++) {
-        for (let j = 0; j < this.columns; j++) {
-          result = result + this.get(i, j) * this.get(i, j);
-        }
-      }
-      return Math.sqrt(result);
-    } else {
-      throw new RangeError(`unknown norm type: ${type}`);
+    switch (type ?? 'frobenius') {
+      case 'max':
+        return this.max();
+      case 'frobenius':
+        return Math.sqrt(this.dot(this));
+      default:
+        throw new RangeError(`unknown norm type: ${type}`);
     }
   }