fix: type check input array (#149)

Check if every element in input array is numeric. Fixes #148
mljs · May 31, 2022 · d8ac6f7 · d8ac6f7
1 parent 7a593b5
commit d8ac6f7
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/__tests__/matrix/creation.js b/src/__tests__/matrix/creation.js
@@ -66,6 +66,14 @@ describe('Matrix creation', () => {
     expect(() => new Matrix()).toThrow(
       /^First argument must be a positive number or an array$/,
     );
+    expect(
+      () =>
+        new Matrix([
+          [1, 2, 3],
+          [4, 5, 6],
+          [7, undefined, 9],
+        ]),
+    ).toThrow(/^Input data contains non-numeric values$/);
   });
 
   it('should correctly set rows, columns and values', () => {

diff --git a/src/matrix.js b/src/matrix.js
@@ -1521,6 +1521,12 @@ function compareNumbers(a, b) {
   return a - b;
 }
 
+function isArrayOfNumbers(array) {
+  return array.every((element) => {
+    return typeof element === 'number';
+  });
+}
+
 // Synonyms
 AbstractMatrix.random = AbstractMatrix.rand;
 AbstractMatrix.randomInt = AbstractMatrix.randInt;
@@ -1562,6 +1568,9 @@ export default class Matrix extends AbstractMatrix {
         if (arrayData[i].length !== nColumns) {
           throw new RangeError('Inconsistent array dimensions');
         }
+        if (!isArrayOfNumbers(arrayData[i])) {
+          throw new TypeError('Input data contains non-numeric values');
+        }
         this.data.push(Float64Array.from(arrayData[i]));
       }
     } else {