Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: type check input array #149

Merged
merged 3 commits into from
May 31, 2022
Merged

Conversation

chrispahm
Copy link
Contributor

Check if every element in input array is numeric, fixes #148

Check if every element in input array is numeric, fixes mljs#148
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #149 (4a38bc5) into main (7a593b5) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   66.62%   66.67%   +0.05%     
==========================================
  Files          32       32              
  Lines        3227     3232       +5     
  Branches      513      514       +1     
==========================================
+ Hits         2150     2155       +5     
  Misses        997      997              
  Partials       80       80              
Impacted Files Coverage Δ
src/matrix.js 76.97% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a593b5...4a38bc5. Read the comment docs.

@stropitek
Copy link
Member

Thank you for the PR!

Could you:

  • Add a test which initializes a matrix with non-numeric values and verifies that it throws an error
  • Run npm run prettier-write to fix the failing test

@stropitek stropitek requested a review from targos May 31, 2022 13:13
Copy link
Member

@stropitek stropitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos targos merged commit d8ac6f7 into mljs:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null values are converted to 0 without warning
3 participants