feat: merge preFinalizeBlockHook #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
force-pushed
the
pre-begin-merge
branch
2 times, most recently
from
6614c9d
to
eb9502b
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
baseapp/abci.go
Outdated
Comment on lines
719
to
740
| WithHeaderHash(req.Hash) | ||
| } | ||
|
|
||
| if app.preFinalizeBlockHook != nil { | ||
| if err := app.preFinalizeBlockHook(app.finalizeBlockState.ctx, req); err != nil { | ||
| if app.preBlocker != nil { | ||
| ctx := app.finalizeBlockState.ctx | ||
| rsp, err := app.preBlocker(ctx, req) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| // rsp.ConsensusParamsChanged is true from preBlocker means ConsensusParams in store get changed | ||
| // write the consensus parameters in store to context |
There was a problem hiding this comment.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:658)
mmsqe
force-pushed
the
pre-begin-merge
branch
from
eb9502b
to
32c5754
Compare
github-actions
bot
added
C:x/evidence
C:x/feegrant
C:x/nft
C:x/upgrade
C:x/circuit
labels
mmsqe
force-pushed
the
pre-begin-merge
branch
from
4429628
to
7443118
Compare
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverse merge
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdmake lintandmake testReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change