Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin pointer literals in code, and julia values in julia_to_scm #63

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Pin pointer literals in code, and julia values in julia_to_scm #63

merged 3 commits into from
Aug 16, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Aug 7, 2024 •
edited
Loading

Julia may embed heap pointers in the code. Those objects cannot be moved, otherwise the pointer value in the code becomes invalid. This PR pins those pointers in literal_pointer_val and literal_static_pointer_val.

Julia also reference heap pointers from scm/flisp values. We pin those heap pointers in julia_to_scm_.

@qinsoon qinsoon changed the base branch from master to v1.9.2+RAI August 7, 2024 05:19
@qinsoon qinsoon mentioned this pull request Aug 7, 2024
Merged
@qinsoon qinsoon force-pushed the pin-pointer-literals branch from 21d24e7 to 0e318f9 Compare August 14, 2024 04:45
@qinsoon qinsoon changed the title Pin pointer literals Pin pointer literals in code, and julia values in julia_to_scm Aug 15, 2024
@qinsoon qinsoon marked this pull request as ready for review August 15, 2024 01:50
@qinsoon qinsoon requested a review from udesou August 15, 2024 01:57
udesou
udesou approved these changes Aug 15, 2024
View reviewed changes
Copy link

@udesou udesou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qinsoon qinsoon merged commit f5f8510 into mmtk:v1.9.2+RAI Aug 16, 2024
3 checks passed
@udesou udesou mentioned this pull request Dec 10, 2024
Merged
qinsoon added a commit that referenced this pull request Dec 18, 2024
@udesou @qinsoon
Pin pointer literals in literal_pointer_val and Julia pointers in jul…
dfd0a0e 
…ia_to_scm (#80)

Backporting #63 to `dev`. 

Co-authored-by: Yi Lin <qinsoon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udesou udesou udesou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qinsoon @udesou