Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pointer literals in code, and julia values in julia_to_scm #63

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Pin pointer literals in code, and julia values in julia_to_scm #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c1a4c0
Pin values in literal_pointer_val
qinsoon Aug 7, 2024
52e80ba
Pin pointers in literal_static_pointer_val
qinsoon Aug 14, 2024
0e318f9
Pin Julia pointers in julia_to_scm_
qinsoon Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/ast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,6 +722,7 @@ static value_t julia_to_list2_noalloc(fl_context_t *fl_ctx, jl_value_t *a, jl_va

static value_t julia_to_scm_(fl_context_t *fl_ctx, jl_value_t *v, int check_valid)
{
PTR_PIN(v);
value_t retval;
if (julia_to_scm_noalloc1(fl_ctx, v, &retval))
return retval;
Expand Down
4 changes: 4 additions & 0 deletions src/cgutils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,9 @@ static Value *literal_pointer_val(jl_codectx_t &ctx, jl_value_t *p)
if (p == NULL)
return Constant::getNullValue(ctx.types().T_pjlvalue);
if (!ctx.emission_context.imaging)
// literal_static_pointer_val will pin p.
return literal_static_pointer_val(p, ctx.types().T_pjlvalue);
PTR_PIN(p);
Value *pgv = literal_pointer_val_slot(ctx, p);
jl_aliasinfo_t ai = jl_aliasinfo_t::fromTBAA(ctx, ctx.tbaa().tbaa_const);
return ai.decorateInst(maybe_mark_load_dereferenceable(
Expand All @@ -487,7 +489,9 @@ static Value *literal_pointer_val(jl_codectx_t &ctx, jl_binding_t *p)
if (p == NULL)
return Constant::getNullValue(ctx.types().T_pjlvalue);
if (!ctx.emission_context.imaging)
// literal_static_pointer_val will pin p.
return literal_static_pointer_val(p, ctx.types().T_pjlvalue);
PTR_PIN(p);
// bindings are prefixed with jl_bnd#
Value *pgv = julia_pgv(ctx, "jl_bnd#", p->name, p->owner, p);
jl_aliasinfo_t ai = jl_aliasinfo_t::fromTBAA(ctx, ctx.tbaa().tbaa_const);
Expand Down
1 change: 1 addition & 0 deletions src/jitlayers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ void add_named_global(StringRef name, void *addr);

static inline Constant *literal_static_pointer_val(const void *p, Type *T)
{
PTR_PIN((void*)p);
// this function will emit a static pointer into the generated code
// the generated code will only be valid during the current session,
// and thus, this should typically be avoided in new API's
Expand Down