Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal tests (including some binding tests) and extended tests. #935

Open
qinsoon opened this issue Sep 1, 2023 · 1 comment
Open

Minimal tests (including some binding tests) and extended tests. #935

qinsoon opened this issue Sep 1, 2023 · 1 comment
Labels
P-high Priority: High. A high-priority issue should be fixed as soon as possible.

Comments

@qinsoon
Copy link
Member

qinsoon commented Sep 1, 2023 •
edited
Loading

We should include some binding tests in the required mmtk-core. The tests are expected to finish in roughly half an hour or so (similar to our current mmtk-core 'pre code review' tests). If we include binding tests, the binding tests should cover some features in MMTk core that is only used by that binding, such as conservative stack scanning in Ruby, discontiguous VM space and transitively pinning in Julia.

We may need to allow a way to specify which binding branches to run in the PR description (currently we can only specify binding branches in PR comments). Otherwise the tests will always fail if a PR has API changes.

We should consider renaming our current tests to minimal tests, and extended tests. The name 'binding tests' is confusing, as it sounds like testing the bindings not mmtk-core.
@k-sareen
Copy link
Collaborator

k-sareen commented Sep 1, 2023 •
edited
Loading

Perhaps a better name would be integration tests?

EDIT: As in, "Julia Integration Test", "OpenJDK Integration Test", etc.

@qinsoon qinsoon added the P-high Priority: High. A high-priority issue should be fixed as soon as possible. label Oct 25, 2023
@qinsoon qinsoon mentioned this issue Jan 8, 2024
Merged
qinsoon added a commit to mmtk/mmtk-openjdk that referenced this issue Jan 17, 2024
@qinsoon
Refactor CI test scripts (#263)
54f6688 
This PR tries to consolidate the new dacapo chopin tests and the old
dacapo 2006 tests to make them consistent. It also exposes tests to
mmtk-core using Github workflows rather than shell scripts (WIP,
mmtk/mmtk-core#935). It fixes the heap sizes
for 2006 tests (mmtk/mmtk-core#424).

Changes in the PR:
* Separate building from testing when we run dacapo 2006 tests
mmtk-openjdk CI.
* Using moderate heap sizes (proportional to the min heap size) to run
dacapo 2006 tests.
* The old `ci-test.sh` still works (binding tests in the mmtk-core repo
is still functioning).

WIP:
* `test-core-extended.yml` and `test-core-minimal.yml`
(mmtk/mmtk-core#935) needs more work. However,
I cannot test them at the moment. Workflow dispatch only works if the
workflows exist in the default branch. I need to get them merged first,
then start modifying and testing them.
@qinsoon qinsoon mentioned this issue Jan 19, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2024
@qinsoon
Rename CI tests to minimal/extended tests (#1073)
de454f5 
This PR refactors the CI workflows for
#935, and run some OpenJDK tests
as minimal tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-high Priority: High. A high-priority issue should be fixed as soon as possible.
Projects
No open projects
v0.20 (20230929)
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qinsoon @k-sareen