Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CI tests to minimal/extended tests #1073

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

qinsoon
Copy link
Member

@qinsoon qinsoon commented Jan 19, 2024

This PR refactors the CI workflows for #935, and run some OpenJDK tests as minimal tests.

@qinsoon
Copy link
Member Author

qinsoon commented Jan 19, 2024

binding-refs
OPENJDK_BINDING_REPO=qinsoon/mmtk-openjdk
OPENJDK_BINDING_REF=mmtk-core-test

@qinsoon qinsoon requested a review from wks January 19, 2024 06:05
@qinsoon qinsoon marked this pull request as ready for review January 19, 2024 06:05
* Minimal tests run unconditionally for every pull request and for every commit. This set of tests aims to finish within half an hour.
This include tests from the `mmtk-core` repo and integration tests from binding repos. Integration tests with a binding in the minimal tests should
focus on testing MMTk core features that is exclusively used for the binding.
* Extended tests only run for a pull request if the pull request is tagged with the label `PR-extended-testing`. This set of tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But extended-tests-bindings.yml still mentions PR-testing. Should that be changed, too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I made that change.

Copy link
Collaborator

@wks wks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinsoon qinsoon added the PR-extended-testing Run extended tests for the pull request label Jan 21, 2024
@qinsoon
Copy link
Member Author

qinsoon commented Jan 23, 2024

@wks Ruby tests kept failing in all the attempts. You may want to look into it. It should not be related to this PR, and I may merge this PR along with the OpenJDK PR.

@wks
Copy link
Collaborator

wks commented Jan 24, 2024

I can reproduce the Rust bug locally, but not stably. It is very random. It happens during GC when marking lines.

@qinsoon qinsoon added this pull request to the merge queue Jan 25, 2024
Merged via the queue into mmtk:master with commit de454f5 Jan 25, 2024
27 of 29 checks passed
@qinsoon qinsoon deleted the minimal-tests-bindings branch January 25, 2024 04:27
github-merge-queue bot pushed a commit that referenced this pull request Apr 16, 2024
We renamed CI tests in #1073, but
forgot to rename them in the ignored list for the merge check. This PR
fixes this.
github-merge-queue bot pushed a commit that referenced this pull request Apr 17, 2024
The extended tests for OpenJDK reuses a workflow, so its action name is
different. We did not use the correct action name since
#1073. It manifested as the merge
check was waiting for the OpenJDK tests to finish and checked its result
before it finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-extended-testing Run extended tests for the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants