Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf: update protobuf compiler #2444

Closed
stevvooe opened this issue Nov 14, 2017 · 1 comment · Fixed by #2448
Closed

protobuf: update protobuf compiler #2444

stevvooe opened this issue Nov 14, 2017 · 1 comment · Fixed by #2448

Comments

@stevvooe
Copy link
Contributor

A new version recently came out: https://github.com/google/protobuf/releases/tag/v3.5.0.

We need to make sure that we don't fall behind so we should update the protobuf compiler used for the build.

This may require updates to the grpc/protobuf etc., but that may not be necessary.

@stevvooe
Copy link
Contributor Author

Looks like the permissions changes in the default protobuf compiler file, so you'll have to set include as readable and set executable on the binary. See containerd/containerd#1761 for an example.

dperny added a commit to dperny/swarmkit-1 that referenced this issue Nov 15, 2017
closes moby#2444

Signed-off-by: Drew Erny <drew.erny@docker.com>
nishanttotla pushed a commit to nishanttotla/swarmkit that referenced this issue Nov 23, 2017
closes moby#2444

Signed-off-by: Drew Erny <drew.erny@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant