-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate protobuf for 3.5 #2451
Merged
anshulpundir
merged 1 commit into
moby:master
from
thaJeztah:regenerate-protobuf-for-3.5
Nov 21, 2017
Merged
Regenerate protobuf for 3.5 #2451
anshulpundir
merged 1 commit into
moby:master
from
thaJeztah:regenerate-protobuf-for-3.5
Nov 21, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also wondering if we can have a check in CI catching this |
CI is failing on flaky test; #2445
|
thaJeztah
force-pushed
the
regenerate-protobuf-for-3.5
branch
from
November 17, 2017 15:12
341461a
to
e496790
Compare
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
- Coverage 66.51% 60.63% -5.88%
==========================================
Files 93 128 +35
Lines 17913 26412 +8499
==========================================
+ Hits 11914 16016 +4102
- Misses 5026 8986 +3960
- Partials 973 1410 +437 |
Protobuf was updated to version 3.5, in commit 9b981e2, but files were not regenerated. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
regenerate-protobuf-for-3.5
branch
from
November 21, 2017 13:30
e496790
to
93c3290
Compare
nishanttotla
approved these changes
Nov 21, 2017
I'm curious how this relates to #2447. cc @anshulpundir |
anshulpundir
approved these changes
Nov 21, 2017
This was referenced Feb 5, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf was updated to version 3.5, in commit
9b981e2 (#2448), but files were not regenerated.
These are the changes after running
make generate
after installing protobuf 3.5Relates to #2444
ping @dperny @stevvooe @anshulpundir