reporters/base: use supports-color to detect colorable term

[parkr]

This replaces #1497.

Detecting whether a terminal is TTY is not enough
to ensure that it can also support color.
This module, supports-color, is a wholistic solution
which captures the greatest range of possible terminals
with the greatest accuracy. The module is extremely
lightweight and does not represent a burdern to Mocha
users.

[dasilvacontin]

LGTM if we fix the build errors.

[jbnicolai]

Looks like the problem is this line. Seems supports-color chose to only support node >= 10.0, probably just to encourage adoption of a more modern node in the ecosystem.

I'll see if I can have it support node >= 8.0.0.

[parkr]

I think @dasilvacontin is right – the ^ character is crazy. I remember being able to use ~ in older versions of node. My guess is this new CL will work.

[dasilvacontin]

I would prefer using the caret character. Can't we just force a higher version of npm? Kinda what we ended up doing at mustache.js: janl/mustache.js#421

[parkr]

I would prefer using the caret character.

What do you prefer about the caret character?

Can't we just force a higher version of npm? Kinda what we ended up doing at mustache.js: janl/mustache.js#421

Force-install a newer version of NPM? That's doable as long as it's compatible with that version of node. When was the caret character introduced?

[dasilvacontin]

rlidwka/sinopia#49 (comment)

With the caret character, we will be getting both minor releases and patches/bugfixes. With the tilde, as soon as they do either a major or a minor release we will stop automatically getting patches and bugfixes.

On a second look, it seems like the philosophy in mocha is manually updating dependencies, since a lot of people rely on this package for their tests.

[sindresorhus]

supportsColor already checks if stdout is TTY, so I think the isatty check could be dropped.

[parkr]

Corrected.

[sindresorhus]

Any reason you're not just using chalk?

[jbnicolai]

@sindresorhus discussed in #1330 and #1325. I'm still all in favor, especially considering we already use supports-color and escape-string-regexp, both of which chalk wraps.

[boneskull]

@sindresorhus, @jbnicolai, @dasilvacontin

Re: fuzzy dependencies (^ vs ~) --fine for devDependencies. We should keep them exact for production dependencies, however.

Would prefer to use chalk or something. Someone just needs to implement it

[parkr]

Ok, this is starting to feel like a wild 🐦 chase. Chalk looks like a pretty big lift – completely reworking the way writing to the console happens. Am I correct in this assumption?

[travisjeffery]

@parkr yep, gonna merge this and we can talk about chalk somewhere else if necessary

[parkr]

Thank you!