Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3336: Make --watch-extensions default to 'js' #3340

Closed
wants to merge 2 commits into from
Closed

#3336: Make --watch-extensions default to 'js' #3340

wants to merge 2 commits into from

Conversation

plroebuck
Copy link
Contributor

Description of the Change

The change in c580294 to --watch-extensions failed to set a default value.
This change specifies that default value.

Benefits

--watch default functionality restored.

Applicable issues

Fixes #3336
(patch release)

@plroebuck
fix(bin/_mocha): Make --watch-extensions default to 'js'
a0a2bd3 
The change in c580294 to `--watch-extensions` failed to set a default value. This change specifies
that default value.

Fixes mochajs#3336
@jsf-clabot
Copy link

jsf-clabot commented Apr 21, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 90.054% when pulling a0a2bd3 on plroebuck:issue/3336 into 3a65a64 on mochajs:master.

plroebuck referenced this pull request Apr 21, 2018
@TheDancingCode @boneskull
remove default js in "--watch-extensions" option; closes #3275
c580294
@boneskull
Copy link
Contributor

This is actually going to be part of v6.0.0 since the functionality that it fixes will land then. master is bleeding-edge code and v5.1.1 doesn’t contain it

@boneskull boneskull added the type: bug a defect, confirmed by a maintainer label Apr 23, 2018
@boneskull boneskull added this to the v6.0.0 milestone Apr 23, 2018
@boneskull
Copy link
Contributor

Thank! landed in 9d407de.

@boneskull boneskull closed this Apr 23, 2018
plroebuck
plroebuck commented Apr 24, 2018
View reviewed changes
Copy link
Contributor Author

@plroebuck plroebuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this was changed, the default value lost its closing quote -- invalid javascript. Why didn't eslint catch that?

@outsideris
Copy link
Contributor

It's weird. eslint should find this kind of errors.

@boneskull
Copy link
Contributor

Part of the problem is likely the lack of filename extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
type: bug a defect, confirmed by a maintainer
Projects
None yet
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@plroebuck @jsf-clabot @coveralls @boneskull @outsideris