Audit for truncf*
#1250
Merged
Audit for truncf*
#1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
reviewed
Jun 7, 2022
| let trunc_res = unsafe { std::intrinsics::truncf32(x) }; | ||
|
|
||
| // The expected result is the number minus its fractional part | ||
| let expected_res = x - x.fract(); |
There was a problem hiding this comment.
Does fract use trunc under the hood?
There was a problem hiding this comment.
Is that a problem for the test, if it's just running (x - f) == (x - f)?
There was a problem hiding this comment.
Yes, it's probably better to avoid it altogether.
It's quite hard to test these functions with symbolic values. Because of that, I've broken the truncf32 test into a three harnesses: One that tests a property for all values and two other for concrete values.
Please let me know what you think! Any suggestions on other tests are welcome.
tedinski
approved these changes
Jun 7, 2022
danielsn
approved these changes
Jun 8, 2022
|
Can you test |
|
Thanks @danielsn , this is now testing that property and a few more concrete cases. |
This was referenced Jun 8, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Restores and completes the audit for the
truncf32(truncf) andtruncf64(trunc) intrinsics.Resolved issues:
Part of #1163
Part of #1025
Call-outs:
Testing:
How is this change tested? Adds 2 tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.