Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for ceilf* #1262

Merged
merged 7 commits into from
Jun 8, 2022
Merged

Audit for ceilf* #1262

merged 7 commits into from
Jun 8, 2022

Conversation

adpaco-aws
Copy link
Contributor

Description of changes:

Restores and completes the audit for the ceilf32 (ceilf) and ceilf64 (ceil) intrinsics.

Resolved issues:

Part of #1163
Part of #1025

Call-outs:

Testing:

  • How is this change tested? Adds 2 tests, removes 2 tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner June 8, 2022 14:59
@adpaco-aws adpaco-aws changed the title Audit for Audit for ceilf* Jun 8, 2022
@adpaco-aws
Copy link
Contributor Author

Updated the tests to follow a similar style as the ones in #1250 (some concrete cases and two properties). In this case, however, the property 0 <= |x - ceil(x)| < 1 does not hold for all cases (very small numbers cause it, and the behavior is reproducible in Rust), so we need to test 0 <= |x - ceil(x)| <= 1.

@adpaco-aws adpaco-aws merged commit 69390ab into model-checking:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants