Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free up additional disk space on GitHub runner #2674

Merged
merged 10 commits into from
Aug 18, 2023

Conversation

tautschnig
Copy link
Member

Description of changes:

Our releasebundle-ubuntu action occasionally failed for it ran out of disk space. (See
https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703 for one such example.

This additional build step cleans out binaries that we do not need, such as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of a total of 84 GB).

Resolved issues:

n/a

Related RFC:

n/a

Call-outs:

n/a

Testing:

  • How is this change tested? CI

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • n/a Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Our releasebundle-ubuntu action occasionally failed for it ran out of disk
space. (See
https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703
for one such example.

This additional build step cleans out binaries that we do not need, such
as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of
a total of 84 GB).
@tautschnig tautschnig requested a review from a team as a code owner August 11, 2023 10:45
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should add this new step to the setup action instead, so most of our jobs would benefit from this cleanup.

@tautschnig tautschnig self-assigned this Aug 18, 2023
@tautschnig
Copy link
Member Author

I was wondering if we should add this new step to the setup action instead, so most of our jobs would benefit from this cleanup.

Done.

@adpaco-aws
Copy link
Contributor

I agree with @zhassan-aws that this is too aggressive. We shouldn't need 28GB ever, and it's good to have less space than that so we can notice performance regressions in the future.

@tautschnig
Copy link
Member Author

I agree with @zhassan-aws that this is too aggressive. We shouldn't need 28GB ever, and it's good to have less space than that so we can notice performance regressions in the future.

I'm now more conservative in what is being removed.

@adpaco-aws adpaco-aws enabled auto-merge (squash) August 18, 2023 19:32
@adpaco-aws adpaco-aws merged commit 2391295 into model-checking:main Aug 18, 2023
12 checks passed
@tautschnig tautschnig deleted the cleanup-runner branch August 19, 2023 05:27
This was referenced Aug 23, 2023
tautschnig added a commit to tautschnig/kani that referenced this pull request Aug 30, 2023
Co-authored-by: Zyad Hassan <88045115+zhassan-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants