Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CBMC version #2702

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Bump CBMC version #2702

merged 2 commits into from
Aug 23, 2023

Conversation

zhassan-aws
Copy link
Contributor

Description of changes:

Upgrade CBMC version in CI to 5.90.0.

Resolved issues:

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Current regressions

  • Is this a refactor change? No

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@zhassan-aws zhassan-aws requested a review from a team as a code owner August 22, 2023 22:43
@zhassan-aws zhassan-aws added the Z-BenchCI Tag a PR to run benchmark CI label Aug 22, 2023
celinval
celinval approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release bundle CI seems to still be broken. Let me see if I can create a patch to fix that.

@zhassan-aws zhassan-aws enabled auto-merge (squash) August 23, 2023 06:23
@tautschnig
Copy link
Member

The release bundle CI seems to still be broken. Let me see if I can create a patch to fix that.

By the looks of the df output it seems that #2674 did not actually yield any additional free space. Trying to debug this in #2704. (In CBMC's CI we do gain approximately 30 GB of memory via such removal.)

@tautschnig
Copy link
Member

I believe #2704 actually does the trick. See the (updated) PR description over there.

@zhassan-aws zhassan-aws merged commit 6c06d4b into model-checking:main Aug 23, 2023
12 checks passed
@zhassan-aws zhassan-aws deleted the cbmc-5.90 branch August 23, 2023 15:59
tautschnig pushed a commit to tautschnig/kani that referenced this pull request Aug 30, 2023
@zhassan-aws @tautschnig
Bump CBMC version (model-checking#2702)
18e7d1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval approved these changes

@feliperodri feliperodri feliperodri approved these changes

Assignees
No one assigned
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhassan-aws @tautschnig @feliperodri @celinval