Fix ICEs due to mismatched arguments #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use FnAbi instead of function signature when generating code for function types. Properly check the `PassMode::Ignore`. For foreign functions, instead of ignoring the declaration type, cast the arguments and return value. For now, we also ignore the caller location, since we don't currently support tracking caller location. This change makes it easier for us to do so. We might want to wait for this issue to get fixed so we can easily add support using stable APIs: rust-lang/project-stable-mir#62
feliperodri
added a commit
that referenced
this pull request
Feb 9, 2024
## What's Changed * `modifies` Clauses for Function Contracts by @JustusAdam in #2800 * Fix ICEs due to mismatched arguments by @celinval in #2994. Resolves the following issues: * #2260 * #2312 * Enable powf*, exp*, log* intrinsics by @tautschnig in #2996 * Upgrade Rust toolchain to nightly-2024-01-24 by @celinval @feliperodri @qinheping **Full Changelog**: kani-0.45.0...kani-0.46.0 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. --------- Signed-off-by: Felipe R. Monteiro <felisous@amazon.com> Co-authored-by: Celina G. Val <celinval@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use FnAbi instead of function signature when generating code for function types. Properly check the
PassMode::Ignore. For foreign functions, instead of ignoring the declaration type, cast the arguments and return value.For now, we also ignore the caller location, since we don't currently support tracking caller location. This change makes it easier for us to do so. We might want to wait for this issue to get fixed so we can easily add support using stable APIs: rust-lang/project-stable-mir#62
Resolves #2260
Resolves #2312
Resolves #1365
Resolves #1350
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.