Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable powf*, exp*, log* intrinsics #2996

Merged
merged 16 commits into from
Feb 7, 2024

Conversation

tautschnig
Copy link
Member

@tautschnig tautschnig commented Feb 6, 2024

CBMC provides approximating implementations of these.

Resolves: #2966

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

CBMC provides approximating implementations of these.

Resolves: model-checking#2763, model-checking#2966
@tautschnig tautschnig requested a review from a team as a code owner February 6, 2024 13:52
@github-actions github-actions bot added the Z-BenchCI Tag a PR to run benchmark CI label Feb 6, 2024
@tautschnig tautschnig self-assigned this Feb 6, 2024
Copy link
Contributor

@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests for exp, and sqrt as well similar to the powf test?

Copy link
Contributor

@adpaco-aws adpaco-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have at least one test for each intrinsic that's being enabled here. I'd recommend separate PRs for each group of intrinsics.

tests/kani/Intrinsics/Math/powf64.rs Outdated Show resolved Hide resolved
docs/src/rust-feature-support/intrinsics.md Outdated Show resolved Hide resolved
@tautschnig
Copy link
Member Author

We need to have at least one test for each intrinsic that's being enabled here. I'd recommend separate PRs for each group of intrinsics.

Yes, more tests need to be added. But doing one PR per group is excessive overhead that I'm not willing to take on.

@rahulku
Copy link
Contributor

rahulku commented Feb 6, 2024

Nudge. I believe there is a customer blocked on this.

Copy link
Contributor

@feliperodri feliperodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM module log tests.

@tautschnig tautschnig changed the title Enable powf*, exp*, sqrt* intrinsics Enable powf*, exp* intrinsics Feb 7, 2024
@tautschnig tautschnig changed the title Enable powf*, exp* intrinsics Enable powf*, exp*, log* intrinsics Feb 7, 2024
@tautschnig tautschnig assigned adpaco-aws and unassigned tautschnig Feb 7, 2024
@adpaco-aws adpaco-aws enabled auto-merge (squash) February 7, 2024 18:42
@adpaco-aws adpaco-aws merged commit f08a3e9 into model-checking:main Feb 7, 2024
19 of 20 checks passed
@tautschnig tautschnig deleted the float-intrinsics branch February 7, 2024 19:08
feliperodri added a commit that referenced this pull request Feb 9, 2024
## What's Changed
* `modifies` Clauses for Function Contracts by @JustusAdam in
#2800
* Fix ICEs due to mismatched arguments by @celinval in
#2994. Resolves the following
issues:
  * #2260
  * #2312
* Enable powf*, exp*, log* intrinsics by @tautschnig in
#2996
* Upgrade Rust toolchain to nightly-2024-01-24 by @celinval @feliperodri
@qinheping

**Full Changelog**:
kani-0.45.0...kani-0.46.0

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Co-authored-by: Celina G. Val <celinval@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-BenchCI Tag a PR to run benchmark CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for powf operations
5 participants