Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: _compute_axis_labels_and_lengths does extra work if the index is already known #4963

Closed
anmyachev opened this issue Sep 13, 2022 · 0 comments · Fixed by #4964
Closed

PERF: _compute_axis_labels_and_lengths does extra work if the index is already known #4963

anmyachev opened this issue Sep 13, 2022 · 0 comments · Fixed by #4964
Assignees
@anmyachev
Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.

Comments

@anmyachev
Copy link
Collaborator

The function returns indices from remote functions (on the basis of which lengths are calculated), basically the time spent on their deserialization / serialization is much more than just using numbers describing lengths and widths.

In some case we able to avoid this.
@anmyachev anmyachev added the Performance 🚀 Performance related issues and pull requests. label Sep 13, 2022
@anmyachev anmyachev self-assigned this Sep 13, 2022
anmyachev added a commit to anmyachev/modin that referenced this issue Sep 13, 2022
@anmyachev
PERF-modin-project#4963: use width/length instead of _compute_axis_la…
6df7714 
…bels_and_lengths

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev mentioned this issue Sep 13, 2022
Merged
8 tasks
@pyrito pyrito added the P2 Minor bugs or low-priority feature requests label Sep 13, 2022
YarShev pushed a commit that referenced this issue Sep 15, 2022
@anmyachev
PERF-#4963: Use partition width/length methods instead of `_compute…
7ced07a 
…_axis_labels_and_lengths` if index is already known (#4964)

Signed-off-by: Myachev <anatoly.myachev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anmyachev anmyachev

Labels
P2 Minor bugs or low-priority feature requests Performance 🚀 Performance related issues and pull requests.
Projects
None yet
Milestone
No milestone
2 participants
@pyrito @anmyachev