Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#4963: Use partition width/length methods instead of _compute_axis_labels_and_lengths if index is already known #4964

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Sep 13, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: _compute_axis_labels_and_lengths does extra work if the index is already known #4963
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

…bels_and_lengths

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #4964 (a240e8f) into master (9fe020b) will increase coverage by 17.98%.
The diff coverage is 77.77%.

@@             Coverage Diff             @@
##           master    #4964       +/-   ##
===========================================
+ Coverage   71.63%   89.61%   +17.98%     
===========================================
  Files         268      268               
  Lines       19737    20014      +277     
===========================================
+ Hits        14139    17936     +3797     
+ Misses       5598     2078     -3520     
Impacted Files Coverage Δ
modin/core/dataframe/pandas/dataframe/dataframe.py 95.11% <77.77%> (+0.50%) ⬆️
...n/core/dataframe/algebra/default2pandas/default.py 86.56% <0.00%> (-11.65%) ⬇️
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
...s/pandas_on_dask/partitioning/virtual_partition.py 89.71% <0.00%> (-0.94%) ⬇️
.../core/dataframe/algebra/default2pandas/__init__.py 100.00% <0.00%> (ø)
...core/dataframe/algebra/default2pandas/dataframe.py 100.00% <0.00%> (ø)
modin/core/dataframe/algebra/default2pandas/any.py
modin/experimental/batch/test/test_pipeline.py 93.84% <0.00%> (ø)
modin/pandas/base.py 95.31% <0.00%> (+0.18%) ⬆️
modin/pandas/dataframe.py 91.48% <0.00%> (+0.21%) ⬆️
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review September 14, 2022 10:16
@anmyachev anmyachev requested a review from a team as a code owner September 14, 2022 10:16
Copy link
Collaborator

@mvashishtha mvashishtha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @anmyachev , thank you!

@YarShev YarShev merged commit 7ced07a into modin-project:master Sep 15, 2022
@anmyachev anmyachev deleted the issue4963 branch September 15, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: _compute_axis_labels_and_lengths does extra work if the index is already known
4 participants