Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5252: Disable notebook tests until access control issues are resolved for modin-test bucket #5257

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

RehanSD
Copy link
Collaborator

@RehanSD RehanSD commented Nov 23, 2022

Signed-off-by: Rehan Durrani rehan@ponder.io

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TEST: CI: CI broken because of 403 HTTPError for taxi CSV on modin-test s3 #5252
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…ssues are resolved for `modin-test` bucket

Signed-off-by: Rehan Durrani <rehan@ponder.io>
@RehanSD RehanSD requested a review from a team as a code owner November 23, 2022 21:00
@RehanSD
Copy link
Collaborator Author

RehanSD commented Nov 23, 2022

Should we add a fix for the places where the bucket is referred to in the docs?

@YarShev
Copy link
Collaborator

YarShev commented Nov 23, 2022

Should we add a fix for the places where the bucket is referred to in the docs?

Maybe some note should be added? Am I correct that other notebooks (e.g., quickstart.ipynb) also don't work for now as those refers to https://modin-test.s3.us-west-1.amazonaws.com/yellow_tripdata_2015-01.csv?

@RehanSD
Copy link
Collaborator Author

RehanSD commented Nov 23, 2022

Should we add a fix for the places where the bucket is referred to in the docs?

Maybe some note should be added? Am I correct that other notebooks (e.g., quickstart.ipynb) also don't work for now as those refers to https://modin-test.s3.us-west-1.amazonaws.com/yellow_tripdata_2015-01.csv?

Yep - any notebook referencing those buckets will fail to run - happy to add a note if folks would like, but maybe we should merge this PR first since it's blocking CI on everything else?

@mvashishtha
Copy link
Collaborator

but maybe we should merge this PR first since it's blocking CI on everything else?

Yep, that's what I would like to do. I will file a follow-up issue for the long term fix, too.

@mvashishtha mvashishtha merged commit 317bd75 into modin-project:master Nov 23, 2022
dchigarev pushed a commit that referenced this pull request Nov 25, 2022
…olved for `modin-test` bucket (#5257)

Signed-off-by: Rehan Durrani <rehan@ponder.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: CI: CI broken because of 403 HTTPError for taxi CSV on modin-test s3
3 participants