Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5252: Disable notebook tests until access control issues are resolved for modin-test bucket #5257

Merged
merged 1 commit into from
Nov 23, 2022
Merged

FIX-#5252: Disable notebook tests until access control issues are resolved for modin-test bucket #5257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/tutorial/jupyter/execution/hdk_on_native/test/test_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import os
import sys
import pytest

import nbformat

Expand Down Expand Up @@ -44,6 +45,9 @@ def test_exercise_1():


# this notebook works "as is"
# GH #5252: Access to the modin-test bucket has changed, so we cannot currently run this test.
# We will need to come back and unskip this test once the access control issue is resolved.
@pytest.mark.skip(reason="Bucket cannot currently be accessed.")
def test_exercise_2():
modified_notebook_path = os.path.join(local_notebooks_dir, "exercise_2_test.ipynb")
nb = nbformat.read(
Expand Down
7 changes: 7 additions & 0 deletions examples/tutorial/jupyter/execution/pandas_on_dask/test/test_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import os
import sys
import pytest

import nbformat

Expand Down Expand Up @@ -46,6 +47,9 @@ def test_exercise_1():


# this notebook works "as is" but for testing purposes we can use smaller dataset
# GH #5252: Access to the modin-test bucket has changed, so we cannot currently run this test.
# We will need to come back and unskip this test once the access control issue is resolved.
@pytest.mark.skip(reason="Bucket cannot currently be accessed.")
def test_exercise_2():
modified_notebook_path = os.path.join(local_notebooks_dir, "exercise_2_test.ipynb")
nb = nbformat.read(
Expand Down Expand Up @@ -99,6 +103,9 @@ def sq_mad_func(self, axis=None, skipna=True, level=None, **kwargs):


# this notebook works "as is" but for testing purposes we can use smaller dataset
# GH #5252: Access to the modin-test bucket has changed, so we cannot currently run this test.
# We will need to come back and unskip this test once the access control issue is resolved.
@pytest.mark.skip(reason="Bucket cannot currently be accessed.")
def test_exercise_4():
modified_notebook_path = os.path.join(local_notebooks_dir, "exercise_4_test.ipynb")
nb = nbformat.read(
Expand Down
7 changes: 7 additions & 0 deletions examples/tutorial/jupyter/execution/pandas_on_ray/test/test_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

import os
import sys
import pytest

import nbformat

Expand Down Expand Up @@ -47,6 +48,9 @@ def test_exercise_1():


# this notebook works "as is" but for testing purposes we can use smaller dataset
# GH #5252: Access to the modin-test bucket has changed, so we cannot currently run this test.
# We will need to come back and unskip this test once the access control issue is resolved.
@pytest.mark.skip(reason="Bucket cannot currently be accessed.")
def test_exercise_2():
modified_notebook_path = os.path.join(local_notebooks_dir, "exercise_2_test.ipynb")
nb = nbformat.read(
Expand Down Expand Up @@ -103,6 +107,9 @@ def sq_mad_func(self, axis=None, skipna=True, level=None, **kwargs):


# this notebook works "as is" but for testing purposes we can use smaller dataset
# GH #5252: Access to the modin-test bucket has changed, so we cannot currently run this test.
# We will need to come back and unskip this test once the access control issue is resolved.
@pytest.mark.skip(reason="Bucket cannot currently be accessed.")
def test_exercise_4():
modified_notebook_path = os.path.join(local_notebooks_dir, "exercise_4_test.ipynb")
nb = nbformat.read(
Expand Down