Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#5413: check Index.dtype instead of isinstance(obj, Int64Index) #5406

Merged
merged 2 commits into from
Dec 12, 2022
Merged

REFACTOR-#5413: check Index.dtype instead of isinstance(obj, Int64Index) #5406

merged 2 commits into from
Dec 12, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Dec 8, 2022 •
edited
Loading

Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: FutureWarning: pandas.Int64Index is deprecated and will be removed from pandas in a future version. #5413
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
REFACTOR-#0000: check Index.dtype instead of Int64Index
8740454 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev
fix test
0fbedee 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title REFACTOR-#0000: check Index.dtype instead of isinstance(obj, Int64Index) REFACTOR-#5413: check Index.dtype instead of isinstance(obj, Int64Index) Dec 9, 2022
@anmyachev anmyachev marked this pull request as ready for review December 9, 2022 13:51
@anmyachev anmyachev requested a review from a team as a code owner December 9, 2022 13:51
@anmyachev
Copy link
Collaborator Author

@dchigarev it would be nice to merge this pull request before release, what do you think?

@dchigarev dchigarev merged commit 1590e65 into modin-project:master Dec 12, 2022
@anmyachev anmyachev deleted the remove-Int64Index branch March 24, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REFACTOR: FutureWarning: pandas.Int64Index is deprecated and will be removed from pandas in a future version.
2 participants
@anmyachev @dchigarev