Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#5413: check Index.dtype instead of isinstance(obj, Int64Index) #5406

Merged
merged 2 commits into from
Dec 12, 2022
Merged

REFACTOR-#5413: check Index.dtype instead of isinstance(obj, Int64Index) #5406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8740454
REFACTOR-#0000: check Index.dtype instead of Int64Index
anmyachev Dec 8, 2022
0fbedee
fix test
anmyachev Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/experimental/core/execution/native/implementations/hdk_on_native/dataframe/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2558,7 +2558,7 @@ def _is_trivial_index(cls, index):
return True
if isinstance(index, pd.RangeIndex):
return index.start == 0 and index.step == 1
if not isinstance(index, pd.Int64Index):
if not (isinstance(index, pd.Index) and index.dtype == np.int64):
return False
return (
index.is_monotonic_increasing
Expand Down
5 changes: 2 additions & 3 deletions ...n/experimental/core/execution/native/implementations/hdk_on_native/test/test_dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1214,12 +1214,11 @@ def applier(df, **kwargs):
# At the end of reduce function it does inevitable `transpose`, which
# is defaulting to pandas. The following logic check that `transpose` is the only
# function that falling back to pandas in the reduce operation flow.
# Another warning comes from deprecated pandas.Int64Index usage.
with pytest.warns(UserWarning) as warns:
res = getattr(df, method)()
assert (
len(warns) == 2
), f"More than two warnings were arisen: len(warns) != 2 ({len(warns)} != 2)"
len(warns) == 1
), f"More than one warning was arisen: len(warns) != 1 ({len(warns)} != 1)"
message = warns[0].message.args[0]
assert (
re.match(r".*transpose.*defaulting to pandas", message) is not None
Expand Down