Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies and CI/CD Setup #109

Merged
merged 7 commits into from
Apr 26, 2020

Conversation

alonraiz
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.914% when pulling 5d6a99d on alonraiz:fix-and-update-ci into ba51e69 on modlinltd:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.914% when pulling 5d6a99d on alonraiz:fix-and-update-ci into ba51e69 on modlinltd:develop.

@asfaltboy
Copy link
Member

Hey @alonraiz can you please add a bit more detail about the PR? What does it do and why?

@alonraiz
Copy link
Contributor Author

Hey @asfaltboy, the original goal of this PR was to make the master branch pass again (since the current master will fail if you trigger it now). after seeing the Travis configuration file I took the liberty of simplifying it, adding more relevant environments and removing deprecated ones (like 3.3)

@asfaltboy asfaltboy self-assigned this Apr 26, 2020
@asfaltboy asfaltboy force-pushed the fix-and-update-ci branch 3 times, most recently from b20888d to ba87a65 Compare April 26, 2020 14:47
@asfaltboy
Copy link
Member

Thanks a lot, @alonraiz, and apologies for the delay.

I took the liberty to fix some of the tests (most likely failed due to pytest/Django versions), and update the .travis.yml to use tox-travis, using your matrix as the basis.

* use tox-travis to keep the travis and tox requirements fairly clean
* drop versions <3.5 and add released 3.8
* use travis python config and specify pypy3.6
* allow any version of coveralls (easier support for python 2.7)
* add up to django 3.0 version according to official dep matrix:

Refs:
- https://www.djangoproject.com/download/#supported-versions
- https://docs.djangoproject.com/en/dev/faq/install/
PetrDlouhy and others added 4 commits April 26, 2020 17:53
due to hard requirement of Django 1.11, it's incompatible with our
wish to still support django versions 1.9 and 1.10
@asfaltboy asfaltboy changed the title Update CI Update Dependencies and CI/CD Setup Apr 26, 2020
@asfaltboy asfaltboy merged commit 0427d11 into modlinltd:develop Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants