Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Smart Response XE #669

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Conversation

twasilczyk
Copy link
Contributor

This change requires merging modm-io/modm-devices#68 first.

@salkinium
Copy link
Member

salkinium commented Aug 21, 2021

You can actually update the modm-devices submodule to your fork's commit (use git add remote to add your fork, then choose the commit) without merging and the CI will work fine. That way you can work on both PRs simultaneously and we can merge them together. I would also prefer to have the BSP and an example in this PR so that the CI can perhaps catch additional issues.

@twasilczyk
Copy link
Contributor Author

Indeed it works pretty well. However the modm-devices pointer in ext/ hasn't been updated in a while so my commit pulls in more changes than just for ATmega128RFA1.

I will add some initial SRXE BSP and example (blinker and maybe uart), but the final implementation will need some separate PRs (e.g. I need to write LCD display driver etc etc).

@twasilczyk twasilczyk force-pushed the develop branch 2 times, most recently from e105953 to 584528c Compare August 21, 2021 20:28
@twasilczyk twasilczyk changed the title Re-enable ATmega128RFA1 Initial support for Smart Response XE Aug 21, 2021
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@twasilczyk twasilczyk marked this pull request as ready for review August 22, 2021 06:01
@twasilczyk
Copy link
Contributor Author

Okay, I think I fixed all the immediate problems. Please let me know if blinky example is good enough for initial PR or it should be more complete with UART and logger.

Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise excellent!

src/modm/board/srxe/board.hpp Show resolved Hide resolved
examples/srxe/blink/main.cpp Outdated Show resolved Hide resolved
examples/srxe/blink/main.cpp Outdated Show resolved Hide resolved
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@salkinium salkinium added the ci:hal Triggers the exhaustive HAL compile CI jobs label Aug 23, 2021
@salkinium salkinium merged commit a173bde into modm-io:develop Aug 23, 2021
@salkinium salkinium added this to the 2021q3 milestone Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:hal Triggers the exhaustive HAL compile CI jobs example 🔑 feature 🚧
Development

Successfully merging this pull request may close these issues.

2 participants